Updated AWS3provider and added option to add pem certificate while cr… #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating connection
| @@ -2,3 +2,4 @@ | |||
| composer.lock | |||
| .DS_Store | |||
| docs | |||
| .idea | |||
There was a problem hiding this comment.
please remove and add to your global .gitignore for this is not project specific, more of a personal ignore.
There was a problem hiding this comment.
Removed .idea from gitignore. Now you can merge :)
|
This pull request broke the "push" functionality for those of us that don't specify a .pem certificate. I get an exception with the message |
|
@marcaube sorry to hear about that inconvenience and thanks for reporting. Just pushed an update to master that should fix that issue. Can you please try with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found an issue while using this package. The issue was :
**
**
Well i found a solution for it which is while making a connection to S3 we haven't option to add PEM certificate so i just added that option and updated readme for future use.