Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow kotlin files #17

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Conversation

sarahBuisson
Copy link

No description provided.

@sarahBuisson
Copy link
Author

@bradflood The pull request pass, the issue in the build is that the sonar cannot be reach. Can anyone do something?

@bradflood
Copy link
Collaborator

bradflood commented Sep 22, 2017

@VinodAnandan I'm looking into some configuration changes for Travis. It appears the SonarCloud Travis addon does not properly invoke the sonar scanner for a pull request not originating within the organization [1] although there are plans to include support for external pull requests [2].

if we want to accept external PRs (recommended), then we'll have to remove the SonarCloud Travis addon and use something similar to what SonarSource does [3]. I've started down that path, but wanted to check with you first before completing. SonarSource has a good example to follow. Should have it ready tomorrow

[1] https://docs.travis-ci.com/user/sonarcloud/#Activation-for-internal-pull-requests
For security reasons, this advanced feature works only for INTERNAL pull requests. In other words, pull requests built from forks won’t be inspected.
[2] https://docs.travis-ci.com/user/sonarcloud/#Upcoming-improvements
[3] https://github.com/SonarSource/sonarqube/blob/master/travis.sh
[4] https://docs.sonarqube.org/display/PLUG/GitHub+Plugin

@VinodAnandan
Copy link
Owner

@sarahBuisson Thank you very much for your valuable contribution to sonar-pitest plugin. This feature will be added to the upcoming release.

@bradflood Thanks a lot for spending time with the Travis integration problems, please go ahead with the improvements.

@VinodAnandan VinodAnandan merged commit 430af89 into VinodAnandan:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants