VP-1638: Chained Stackable policy discounts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yecli
commented
Mar 16, 2020
yecli
commented
- After applying reward that could affect discount on cart total remaining discount conditions are re-evaluated;
- Shipment rewards are applied after items and subtotal rewards now to allow shipment promotion use discounted cart subtotal in conditions;
- Added test for applying rewards with the same priority;
- After applying reward that could affect discount on cart total remaining discount conditions are re-evaluated; - Shipment rewards are applied after items and subtotal rewards now to allow shipment promotion use discounted cart subtotal in conditions; - Added test for applying rewards with the same priority;
- Added `IPromotionRewardEvaluator` abstraction to allow testing call times; - Fixed problem with one promotion should apply all its different type rewards in one iteration; - Added tests checking IPromotionRewardEvaluator calls count in different cases;
vc-ci
reviewed
Mar 17, 2020
| return result; | ||
| } | ||
|
|
||
| protected virtual void EvalAndCombineRewardsRecursively(PromotionEvaluationContext context, Func<PromotionEvaluationContext, IEnumerable<PromotionReward>> evalFunc, ICollection<PromotionReward> resultRewards, ICollection<PromotionReward> skippedRewards) | ||
| protected virtual void EvalAndCombineRewardsRecursively(PromotionEvaluationContext context, IEnumerable<Promotion> promotions, ICollection<PromotionReward> resultRewards, ICollection<PromotionReward> skippedRewards) |
There was a problem hiding this comment.
- Now in Stackable policy rewards are grouped by promotions priorities so only same priority promotions are applied on one iteration. Thus we have the ability to strictly manage the order of all promotion appliance; - Added test for sequential priorities appliance;
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
tatarincev
approved these changes
Mar 18, 2020
yecli
deleted the
feature/VP-1638-discounted-total-chained-reward-appliance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.