PricingSearchService: search extensibility improvements #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assignments query building to separate virtual methods to simplify extension of pricing search.
… project - it is missing.
yecli
approved these changes
Jan 27, 2020
tatarincev
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HOT, we needed to extend pricelist assignments search by our custom pricelist assignment fields. But this required us to copy the entire
PricingSearchServiceImpl.SearchPricelistAssignments()method and add custom properties handling to it, because database query building is inlined right into the body of this method. So, this PR extracts database query building to separate virtual methods - this will make extending search of pricing entities much simpler (all we'll need to do is just to override the needed query building and filtering method).Also, this PR removes the
Model/ModelDiagram.cdreference from theVirtoCommerce.PricingModule.Data.csproj- the file is missing anyway, so there is no point to have it in the project.