Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase precision for decimals to store more than 2 decimal values #608

Closed
Skrypt opened this issue Sep 7, 2016 · 5 comments
Closed

Increase precision for decimals to store more than 2 decimal values #608

Skrypt opened this issue Sep 7, 2016 · 5 comments
Assignees
@pushnitsa
Labels
backend client request developer pain problem

Comments

@Skrypt
Copy link
Contributor

Skrypt commented Sep 7, 2016

I noticed that the decimal values gets rounded in the admin UI when I type a decimal value for a numeric property. Let me know if you guys can reproduce or if it's just me.
@tatarincev tatarincev added this to the 'Dandelion' milestone Sep 7, 2016
@eMazeika
Copy link

eMazeika commented Sep 7, 2016

Only 2 decimal digits precision is currently supported. We should change that to allow higher precision for decimals.

@eMazeika eMazeika changed the title PropertyValue rounding when decimal Increase precision for decimals to store more than 2 decimal values Sep 7, 2016
@eMazeika eMazeika modified the milestones: Backlog, 'Dandelion' Sep 7, 2016
@tatarincev tatarincev modified the milestones: Operations, Backlog Mar 14, 2017
@OlegoO OlegoO modified the milestones: Product Backlog, Operations Sep 5, 2017
@OlegoO
Copy link
Contributor

OlegoO commented Sep 5, 2017

In MS SQL, we have used decimal(18,2). Need to review how we can migrate and store more than 2 decimal values

@tatarincev tatarincev assigned pushnitsa and unassigned eMazeika and tatarincev May 17, 2018
@tatarincev tatarincev modified the milestones: Product Backlog, Operations May 17, 2018
@tatarincev
Copy link
Contributor

tatarincev commented May 17, 2018 •
edited
Loading

Need to increase precision (to 5) for all decimal columns in all platform tables.

See commit for the similar task:
VirtoCommerce/vc-module-order@1133ed1

The article describes how to work with migrations in VC.
https://virtocommerce.com/docs/vc2devguide/working-with-platform-manager/extending-functionality/managing-module-database

@pushnitsa
Copy link
Contributor

image
image

@tatarincev
Copy link
Contributor

https://github.com/VirtoCommerce/vc-platform/releases/tag/v2.13.27

@artem-dudarev artem-dudarev mentioned this issue May 25, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pushnitsa pushnitsa

Labels
backend client request developer pain problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Skrypt @eMazeika @tatarincev @OlegoO @artem-dudarev @pushnitsa