Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PT-82: Configuration of password expiration policy #2193

Merged
merged 9 commits into from Mar 30, 2021
Merged

PT-82: Configuration of password expiration policy #2193

merged 9 commits into from Mar 30, 2021

Conversation

eMazeika
Copy link

vc-ci
vc-ci reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 3
Failures: 0
Errors: 0
Time: 4.577
Timestamp: 2021-03-26 09:27:17

vc-ci
vc-ci reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 3
Failures: 0
Errors: 0
Time: 4.674
Timestamp: 2021-03-26 09:32:12

@eMazeika eMazeika changed the title Configuration of password expiration policy PT-81: Configuration of password expiration policy Mar 26, 2021
vc-ci
vc-ci reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 3
Failures: 0
Errors: 0
Time: 4.726
Timestamp: 2021-03-26 11:55:43

tatarincev
tatarincev requested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@tatarincev tatarincev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need write unit-tests for this logic

src/VirtoCommerce.Platform.Security/Repositories/SecurityDbContext.cs Outdated Show resolved Hide resolved
src/VirtoCommerce.Platform.Core/Security/UserOptionsExtended.cs Outdated Show resolved Hide resolved
src/VirtoCommerce.Platform.Web/Controllers/Api/AuthorizationController.cs Outdated Show resolved Hide resolved
vc-ci
vc-ci reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 17
Failures: 3
Errors: 0
Time: 32.669
Timestamp: 2021-03-29 09:18:46

@VirtoCommerce VirtoCommerce deleted a comment from mvktsk Mar 29, 2021
vc-ci
vc-ci reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 17
Failures: 2
Errors: 0
Time: 29.551
Timestamp: 2021-03-29 14:25:25

vc-ci
vc-ci reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 17
Failures: 2
Errors: 0
Time: 27.848
Timestamp: 2021-03-29 15:25:14

@Vectorfield4 Vectorfield4 changed the title PT-81: Configuration of password expiration policy PT-82: Configuration of password expiration policy Mar 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.7% 53.7% Coverage
0.0% 0.0% Duplication

vc-ci
vc-ci reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Platform_start
Tests: 17
Failures: 2
Errors: 0
Time: 26.927
Timestamp: 2021-03-29 22:05:14

@eMazeika eMazeika merged commit 021a9ec into dev Mar 30, 2021
@eMazeika eMazeika deleted the feature/PT-81-password branch March 30, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vc-ci vc-ci vc-ci left review comments

@tatarincev tatarincev tatarincev approved these changes

@akak1977 akak1977 akak1977 approved these changes

@ksavosteev ksavosteev ksavosteev approved these changes

@Vectorfield4 Vectorfield4 Vectorfield4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eMazeika @tatarincev @akak1977 @ksavosteev @vc-ci @Vectorfield4 @mvktsk