Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some style inconsistencies on the website #1037

Closed
2 tasks done
datsfilipe opened this issue Oct 6, 2023 · 2 comments
Closed
2 tasks done

Some style inconsistencies on the website #1037

datsfilipe opened this issue Oct 6, 2023 · 2 comments
Labels
Status: Needs Triage This issue hasn't been reviewed by maintainers yet. Type: bug Something isn't working

Comments

@datsfilipe
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Well, I've noticed some problems with the styles on the website, like:

The header animation on scroll is not fully complete at some point (which is okay), but it starting from the bottom makes it looks strange. Seems that the header is also disappearing when focusing another window, but I'm not sure about that.

Other than that, some hover states should be added to footer and header links, and some buttons too. I think this would improve the UI of the website a lot!

Steps To Reproduce

  1. Scroll the page slowly to notice the header animation state in the image I will give below.
  2. Hover links and buttons having no hover state.

What browsers are you seeing the problem on?

Chrome

Environment

- OS: Arch
- Node: not relevant
- pnpm: not relevant

Anything else?

Here a image showing the header animation on scroll when it looks strange:

image

I will not take screenshots of the other things but if you visist the website you will notice the links behavior and so on.

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Virtual Coffee community
@datsfilipe datsfilipe added Status: Needs Triage This issue hasn't been reviewed by maintainers yet. Type: bug Something isn't working labels Oct 6, 2023
@danieltott
Copy link
Member

Hey @datsfilipe - thanks for the issue!

We already have an issue about the navbar, although most of what you describe is by design: #823

The header links do have a hover state, and since the footer links are so simple, I don't really think they need a hover state.

I'm going to go ahead and close this issue, but thank you again for taking a look!

@danieltott danieltott closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
@datsfilipe
Copy link
Author

datsfilipe commented Oct 6, 2023

Oh, didn't saw that issue about the navbar, my bad. But still, the links state is not intuitive for the end user at all. Not having hover states is pretty awful, but not just that, look:

Peek.2023-10-06.12-09.mp4

The user clicking on the background and being redirected to another website is the oppositte of intuitive. It's not even a UI issue, but a UX one. But it's okay if you don't think those changes are necessary! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage This issue hasn't been reviewed by maintainers yet. Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants