Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peekaboo with the navigation bar #823

Closed
2 tasks done
bogdaaamn opened this issue Mar 3, 2023 · 18 comments
Closed
2 tasks done

Peekaboo with the navigation bar #823

bogdaaamn opened this issue Mar 3, 2023 · 18 comments
Labels
Type: bug Something isn't working

Comments

@bogdaaamn
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Not sure if this is a bug or a feature, but the nav bar is visible but not interactive on scroll up all the way up on the landing page. Also it stay visible if there is focus within.

Screen.Recording.2023-03-03.at.11.52.31.mov

I think the idea is to hide the bar when scrolled all the way up and reveal it later, right? But I scrolled too much and revealed the bar by mistake, I can't unsee it and I wanna press it 😭

Steps To Reproduce

  1. Go to https://virtualcoffee.io/
  2. Scroll up for no reason

What browsers are you seeing the problem on?

Chrome

Environment

- OS: MacOS Ventura 13.0

Anything else?

I love issues forms, I didn't know we have them omg

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Virtual Coffee community
@bogdaaamn bogdaaamn added Status: Needs Triage This issue hasn't been reviewed by maintainers yet. Type: bug Something isn't working labels Mar 3, 2023
@redapy
Copy link
Contributor

redapy commented Mar 21, 2023

@bogdaaamn @BekahHW what is the expected behavior?

@danieltott
Copy link
Member

This is the expected behavior 👍🏼

@danieltott
Copy link
Member

OH - nm, i watched the video. this isn't scroll all the way up, it's scroll past the top. That's interesting. Can we disable it? or cover it somehow.

@danieltott danieltott reopened this Mar 21, 2023
@danieltott
Copy link
Member

Looks like overscroll-behavior-y:none might do it

@bogdaaamn
Copy link
Member Author

it's me

@danieltott
Copy link
Member

@redapy you interested?

@dreymoreau
Copy link

hi! i would like to fix this bug :)

@danieltott danieltott removed the Status: Needs Triage This issue hasn't been reviewed by maintainers yet. label Mar 22, 2023
@danieltott
Copy link
Member

@dreymoreau it's all you!

@dreymoreau
Copy link

readme png
error png

@danieltott hi! followed the readme instructions but got this error when trying to build, wondering about further clarification on how to get it working when building locally?

@redapy
Copy link
Contributor

redapy commented Mar 22, 2023

@danieltott sorry for the late response, I was a bit busy. However, I can't reproduce the behavior on my MacOS Monterey 12.6. Please let me know if there is anything I can help with!

@danieltott
Copy link
Member

@dreymoreau just to cover our bases, I assume you tried to stop the server and re-start it?

Also, can you paste in the following versions:

  • Node (node -v)
  • yarn (yarn -v)
  • netlify-cli (netlify-cli -v)

@dreymoreau
Copy link

dreymoreau commented Apr 7, 2023

hi! @danieltott sorry for getting back to you late
node version : 19.8.1
yarn version: 1.22.19
for netlify-cli, it prompts this even though i have it installed and have used the command for the latest version

Preview README md - virtual-coffee - Visual Studio Code 2023-04-07 5_11_03 PM

@sameer-soni
Copy link

Hi there! I've created a pull request (#959 ) to address this issue. Please take a look when you have a moment. Thanks!

@danieltott
Copy link
Member

@dreymoreau I'm sorry about the delay helping you out here. Do you still want to take a crack at this? I believe @adiati98 has gotten the site running on windows so she may be able to help...

@adiati98
Copy link
Contributor

adiati98 commented Oct 6, 2023

@danieltott as this is on the homepage where we need to fetch (fake?) data, it always crash on Windows.
I mostly work on newsletter and monthly challenge pages where we don't need to fetch data from 3rd party.
I have no solution yet on this for Windows users.

One way is to work on this blindly, and create a draft PR.
We can always see the result through Netlify. This is what I normally do when necessary 😁.

@dreymoreau dreymoreau removed their assignment Oct 6, 2023
@dominicduffin1
Copy link
Contributor

If @dreymoreau still wants to work on this I might be able to help figure out how to get it running on Windows (I believe I did get it running in the past but I can't remember how🙂). Another option if your system supports it is to try Windows Subsystem for Linux (which I can also help with).

@adiati98
Copy link
Contributor

@dominicduffin1 I will be interested to know how to get the homepage running on Windows (not WSL... yet 😁).

danieltott added a commit that referenced this issue Sep 30, 2024
@danieltott
Copy link
Member

closed via 74a0c07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants