AWS WAF-Cognito setup for the MVP-environments #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsipii
commented
Aug 19, 2023
•
lsipii
commented
- restrict access to the mvp-environments using the tech combinations of WAF (Web Application Firewall) and AWS Cognito
- note: the solution is not secure, but good for the current requirements
- note: the first-time deployment must be done twice to resolve the circular dependency loop: How to solve Chicken & Egg problem / cyclic dependencies / update resources? pulumi/pulumi#3021 (comment)
lsipii
changed the title
LauriGofore
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Tämä näyttää eheältä. 👍 Ainut asia mikä tuli mieleen että irrottaisiko tuon cognito-osuuden vielä omaan moduuliinsa, niin sit ois kivasti kaikki resut omissa lokeroissaan. Tosin tuo on aika tightly coupled tuon waffin kanssa joten eipä tarvis ylikomplikoida.
Ja heh, "hauska" tämä circular deps tilanne. Varmaan jos ois jostain giganttisesta setupista kyse, niin ehkä yks ratkaisu vois olla kahteen/useampaan pulumiäppsiin jaottelu, mitkä olisivat toisiinsa sidoksissa ja ci-pipessä ajella deplaukset oikeassa järjestyksessä.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.