Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/352 #1405

Merged
merged 2 commits into from Apr 18, 2023
Merged

Feature/352 #1405

merged 2 commits into from Apr 18, 2023

Conversation

jrmartin
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

@jrmartin jrmartin marked this pull request as ready for review April 18, 2023 16:10
@jrmartin
Copy link
Contributor Author

@Robbie1977 I opened a PR with a fix for this #1405.
The webpack was missing a rule for mjs files, which are now used by some node modules.

Here is the last deployment of the branch, virgo server starts and no issue during build. Tests are failing to run, but that's a different issue I think.
image

@Robbie1977 Robbie1977 merged commit 879f90b into development Apr 18, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrmartin @Robbie1977