Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1.18.2 compat #2

Closed
wants to merge 6 commits into from
Closed

add 1.18.2 compat #2

wants to merge 6 commits into from

Conversation

triphora
Copy link
Contributor

@triphora triphora commented Jan 27, 2022

The signature of the methods had to be changed as there was a new local variable, and the ordinal had to be changed from 0 to 1 for the two that used 1.

link for anyone who wants it: https://cdn.discordapp.com/attachments/745979270748307458/951967909943586866/NoFog-1.2.01.16.5-1.18.2.jar

@triphora triphora changed the title add 22w03a compat add 22w06a compat Feb 9, 2022
@triphora
Copy link
Contributor Author

triphora commented Feb 9, 2022

Updated to 22w06a. Probably won't work on older versions, since I'm not sure how you want me to abstract stuff like the registry changes.

@Virtuoel
Copy link
Owner

Virtuoel commented Feb 9, 2022

Had a feeling something breaking was coming with vanilla, hence why I didn't merge earlier, but I didn't expect the break to be registry changes. With that sort of sweeping change to vanilla, might be best to wait until 1.18.2 is fully out before merging to make sure we don't get hit by any further big changes.

@triphora
Copy link
Contributor Author

triphora commented Feb 9, 2022

Right, I wasn't expecting you to merge until then, but I had made the changes for my personal 22w03a/06a world and thought I might as well PR them /shrug

@triphora triphora marked this pull request as draft February 9, 2022 23:11
@triphora triphora marked this pull request as ready for review March 5, 2022 00:40
@Ynng
Copy link

Ynng commented Mar 11, 2022

The fork worked on 1.18.2 for me, mod menu also works fine: https://github.com/wafflecoffee/NoFog/pull/1

@Virtuoel
Copy link
Owner

This PR does work fine. Once the weekend comes around, this will be merged and updated for 1.18.2.

@triphora triphora changed the title add 22w06a compat add 1.18.2 compat Mar 11, 2022
Virtuoel added a commit that referenced this pull request Mar 14, 2022
@Virtuoel
Copy link
Owner

Merged in 760eb89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants