-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to other resources by reference instead of ID #144
Labels
area/codegen
Schema to code generator
impact/usability
Something that impacts users' ability to use the product easily and intuitively
kind/improvement
An improvement with existing workaround
Milestone
Comments
pawelprazak
added
kind/improvement
An improvement with existing workaround
area/codegen
Schema to code generator
impact/usability
Something that impacts users' ability to use the product easily and intuitively
labels
Sep 21, 2023
This might be related: pulumi/pulumi#8412 |
How does it work? What is the definition of RestAPI resource? |
this codegen log looks related:
|
lbialy
added a commit
that referenced
this issue
Sep 26, 2023
lbialy
added a commit
that referenced
this issue
Sep 26, 2023
pawelprazak
added a commit
that referenced
this issue
Nov 13, 2023
- allow for a union of ID and Resource in inputs Fixes #144
I was able to get the correct type resolved in unit tests, from this schema: {
"type": "string",
"oneOf": [
{
"type": "string"
},
{
"type": "string",
"$ref": "#/types/aws:apigateway%2FrestApi:RestApi"
}
],
"willReplaceOnChanges": true
} into but, there is another issue, the generated code has
|
This was referenced Nov 13, 2023
pawelprazak
added a commit
that referenced
this issue
Dec 1, 2023
This was referenced Dec 1, 2023
Closed
pawelprazak
added a commit
that referenced
this issue
Dec 14, 2023
pawelprazak
added a commit
that referenced
this issue
Dec 19, 2023
Added to codegen in #332 |
Almost there:
|
pawelprazak
added a commit
that referenced
this issue
Jan 18, 2024
pawelprazak
added a commit
that referenced
this issue
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/codegen
Schema to code generator
impact/usability
Something that impacts users' ability to use the product easily and intuitively
kind/improvement
An improvement with existing workaround
TypeScript:
(another example)
What we generate currently:
Relevant schema:
The text was updated successfully, but these errors were encountered: