Update codegen and package generator #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pawelprazak
commented
Dec 14, 2023
•
pawelprazak
commented
- add codegen for provider config (fixes We are missing Config in codegen #259)
- add resource references (fixes Refer to other resources by reference instead of ID #144)
- fix dots in package segments in codegen
- fix deserialization of empty ObjectTypeDefinitionOrTypeReference
- resolve dependencies during package generation and publish
- disable bloop for packages
- use 32GB heap for package compilation
- uncomment two fixed codegen integration tests
pawelprazak
added
kind/cleanup
Closed
pawelprazak
added
kind/missing
pawelprazak
force-pushed
the
pprazak/update-codegen
branch
from
ef02ff0
to
fb4ab5b
Compare
- fix deserialization of empty ObjectTypeDefinitionOrTypeReference - resolve dependencies during package generation and publish - disable bloop for packages - use 32GB heap for package compilation - uncomment two fixed codegen integration tests
This was referenced Dec 19, 2023
- add stringEnumReader, booleanEnumReader, intEnumReader, doubleEnumReader to ConfigValueReader
pawelprazak
force-pushed
the
pprazak/update-codegen
branch
from
fb4ab5b
to
fcfe0ea
Compare
pawelprazak
commented
Jan 11, 2024
- fix decoder for Boolean | String - add unionDecoders: - unionDecoder3 - unionDecoder4 - unionDecoder5 - unionDecoder6 - unionDecoder7 - unionDecoder8
lbialy
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
LGTM in regard to not throwing. Shared reservations about naive unionDecoders in private (basically that if A is a subset of fields of B it will parse correctly and win although the correct choice was B, has to be solved with a heuristic in codegen to always sort from types with the most fields to least fields).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.