Skip to content

Commit

Permalink
Hardcode upgradeCodeGuid in wix installer to remove previous scala-cl…
Browse files Browse the repository at this point in the history
…i version

Added upgradeCodeGuidID from scala-cli msi installer 0.1.5. From this version, when someone install scala-cli with msi, the installer by default remove previous version.
  • Loading branch information
lwronski committed Oct 12, 2022
1 parent 5fb9198 commit 00187f2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/scripts/generate-os-packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ generate_msi() {
--exit-dialog "To run Scala CLI, open a Command window, and type scala-cli + Enter. If scala-cli cannot be found, ensure that the Command window was opened after Scala CLI was installed." \
--logo-path "./logo.png" \
--suppress-validation \
--extra-configs wix-visual-cpp-redist.xml
--extra-configs wix-visual-cpp-redist.xml \
--wix-upgrade-code-guid "C74FC9A1-9381-40A6-882F-9044C603ABD9"
rm -f "$ARTIFACTS_DIR/"*.wixpdb || true
}

Expand Down
4 changes: 4 additions & 0 deletions website/docs/reference/cli-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,10 @@ Whether a 64-bit executable is being packaged

WIX installer version

### `--wix-upgrade-code-guid`

The GUID to identify that the windows package can be upgraded.

### `--docker-from`

Building the container from base image
Expand Down

0 comments on commit 00187f2

Please sign in to comment.