Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using directive for Scala Js options #332

Closed
romanowski opened this issue Nov 2, 2021 · 3 comments
Closed

Using directive for Scala Js options #332

romanowski opened this issue Nov 2, 2021 · 3 comments
Assignees
@lwronski
Labels
good first issue Good for newcomers
Projects
0.1 - scala-cli for scripts, micro pr...

Comments

@romanowski
Copy link
Member

Scala CLI allows configuring following options for Scala JS:

  • jsVersion
  • jsModuleKind
  • jsDom

We are missing using directives parser for them similar to one for JavaOptions.
@romanowski romanowski added the good first issue Good for newcomers label Nov 2, 2021
@sjrd
Copy link

sjrd commented Nov 2, 2021

Also worth pointing out that even the "options for Scala.js" that scala-cli seems to handle are missing several options of Scala.js itself:
https://github.com/scala-js/scala-js/blob/master/linker-interface/shared/src/main/scala/org/scalajs/linker/interface/StandardConfig.scala
including important ones like esFeatures and moduleSplitStyle.

@romanowski
Copy link
Member Author

Per #531 we should also include jsHeader option.

@lwronski lwronski self-assigned this Jan 11, 2022
@lwronski
Copy link
Contributor

Closed #332 via #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lwronski lwronski

Labels
good first issue Good for newcomers
Projects
No open projects
0.1 - scala-cli for scripts, micro pr...
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjrd @romanowski @lwronski