Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static linking of libsodium in Windows launcher #1115

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Fix static linking of libsodium in Windows launcher #1115

merged 3 commits into from
Jun 28, 2022

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Jun 16, 2022 •
edited
Loading

Fixes #1114 (hopefully)

@alexarchambault

This comment was marked as outdated.

Sign in to view
@alexarchambault alexarchambault mentioned this pull request Jun 17, 2022
Closed
@alexarchambault alexarchambault marked this pull request as ready for review June 20, 2022 17:02
@alexarchambault
Copy link
Contributor Author

alexarchambault commented Jun 20, 2022 •
edited
Loading

Thinking about add a check using dumpbin /dependents, to check if the Windows launcher has unexpected DLL dependencies. But we can always merge this PR, as it fixes an important issue (Windows launcher not working).

@alexarchambault alexarchambault merged commit 4402c80 into VirtusLab:main Jun 28, 2022
@alexarchambault alexarchambault deleted the fix-sodium-dll-issue-windows branch June 28, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing libsodium.dll on windows
2 participants
@alexarchambault @Gedochao