Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable turning --interactive mode on permanently #1238

Merged
merged 3 commits into from Aug 8, 2022
Merged

Enable turning --interactive mode on permanently #1238

merged 3 commits into from Aug 8, 2022

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Aug 4, 2022

Closes #1177

@Gedochao Gedochao force-pushed the interactive-global branch 2 times, most recently from 127a476 to 1205a35 Compare August 5, 2022 09:22
@Gedochao Gedochao marked this pull request as ready for review August 8, 2022 08:01
wleczny
wleczny approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@wleczny wleczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit beda0b5 into VirtusLab:main Aug 8, 2022
@Gedochao Gedochao deleted the interactive-global branch August 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wleczny wleczny wleczny approved these changes

@lwronski lwronski Awaiting requested review from lwronski

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable turning --interactive mode on permanently
2 participants
@Gedochao @wleczny