Fix calculation of Scala version and turn off the -release flag for 2.12.x < 2.12.5
#1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
changed the title
-release flag for 2.12.x < 2.12.5-release flag for 2.12.x < 2.12.5
lwronski
reviewed
Sep 20, 2022
Gedochao
force-pushed
the
fix-scala-2.12.1-to-2.12.4
branch
from
d7df0a6
to
59ab39b
Compare
lwronski
approved these changes
Sep 20, 2022
Comment on lines
+831
to
+832
| if params.scalaVersion.startsWith("2.12") && | ||
| params.scalaVersion.maybeScalaPatchVersion.exists(_ < 5) |
There was a problem hiding this comment.
No big deal, but version comparison with coursier.core.Version could have worked here, it seems, like
val sv = coursier.core.Version(params.scalaVersion)
if params.scalaVersion.startsWith("2.12.") && sv.compareTo(coursier.core.Version("2.12.15")) < 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372
Fixes #1373
However, code still doesn't compile on Scala
2.12.0and compiles infinitely on2.12.4, which should be addressed separately.