Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure package doesn't trigger a re-compilation after run #1406

Merged

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault

This comment was marked as resolved.

@alexarchambault

This comment was marked as outdated.

@alexarchambault alexarchambault force-pushed the more-internal-options branch 2 times, most recently from d97078a to 6cba202 Compare September 30, 2022 12:39
This makes project_* directories under .scala-build have names like
project_0ad289ebaa rather than project_0ad289ebaa_0ad289ebaa most of the
time (when test options don't differ from the ones in the main scope).
So that commands that change their defaults (like package, which
disables the JVM runner) don't end up with a different options hash,
which would make the project end up in a different directory under
.scala-build. That way, running a 'scala-cli run …' command, then
'scala-cli package …' makes the latter re-use the build products of the
former, rather than re-compiling things.
@alexarchambault alexarchambault marked this pull request as ready for review October 3, 2022 10:25
@alexarchambault alexarchambault merged commit fbae12c into VirtusLab:main Oct 5, 2022
@alexarchambault alexarchambault deleted the more-internal-options branch October 5, 2022 09:21
@Gedochao Gedochao added the internal Internal or build-related changes label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants