Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge documentation of installing scala-cli on MacOs and MacOs/M1 #1507

Merged
merged 1 commit into from Nov 7, 2022

Conversation

wleczny
Copy link
Contributor

@wleczny wleczny commented Oct 29, 2022

No description provided.

@wleczny wleczny requested review from lwronski and Gedochao and removed request for lwronski November 1, 2022 06:37
@wleczny wleczny marked this pull request as ready for review November 1, 2022 06:38
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's too early to merge, for M1 we don't support nix.

@wleczny wleczny force-pushed the install-documentation-update branch from 096fc4d to 1884c33 Compare November 2, 2022 07:48
@wleczny
Copy link
Contributor Author

wleczny commented Nov 2, 2022

I think it's too early to merge, for M1 we don't support nix.

Since every other method is already supporting M1, I would suggest just to add information to nix installation, that it doesn't support M1.

@wleczny wleczny requested a review from lwronski November 2, 2022 07:59
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
@wleczny wleczny force-pushed the install-documentation-update branch 5 times, most recently from 134d806 to bab4892 Compare November 2, 2022 14:12
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
website/docs/_advanced_install.mdx Outdated Show resolved Hide resolved
@wleczny wleczny force-pushed the install-documentation-update branch 2 times, most recently from dd393f5 to aa7b96d Compare November 2, 2022 14:37
@wleczny wleczny requested a review from Gedochao November 2, 2022 16:14
@wleczny wleczny force-pushed the install-documentation-update branch from aa7b96d to 3d46402 Compare November 2, 2022 16:16
@Gedochao Gedochao added the documentation Improvements or additions to documentation label Nov 4, 2022
@wleczny wleczny merged commit 058a092 into VirtusLab:main Nov 7, 2022
@wleczny wleczny deleted the install-documentation-update branch November 7, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants