New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge documentation of installing scala-cli on MacOs and MacOs/M1 #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleczny
requested review from
lwronski and
Gedochao
and removed request for
lwronski
November 1, 2022 06:37
lwronski
suggested changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's too early to merge, for M1 we don't support nix.
wleczny
force-pushed
the
install-documentation-update
branch
from
November 2, 2022 07:48
096fc4d
to
1884c33
Compare
Since every other method is already supporting M1, I would suggest just to add information to nix installation, that it doesn't support M1. |
Gedochao
reviewed
Nov 2, 2022
wleczny
force-pushed
the
install-documentation-update
branch
5 times, most recently
from
November 2, 2022 14:12
134d806
to
bab4892
Compare
Gedochao
reviewed
Nov 2, 2022
wleczny
force-pushed
the
install-documentation-update
branch
2 times, most recently
from
November 2, 2022 14:37
dd393f5
to
aa7b96d
Compare
wleczny
force-pushed
the
install-documentation-update
branch
from
November 2, 2022 16:16
aa7b96d
to
3d46402
Compare
Gedochao
approved these changes
Nov 3, 2022
lwronski
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.