Refactor landing page and add pages for each usecase. #151

romanowski · 2021-09-25T00:21:42Z

No description provided.

website/src/components/basicInstall.js

lwronski · 2021-09-27T08:08:00Z

website/src/components/features.js

+      <p>
+        scala-cli is built on top of coursier
+        <br/>
+        This allow us to manage Scala versions, dependencies and JVMs so you can test your code in different environments by changing single option.


I have doubt it should be here 'single option', because it requires changing a few options, not just one

One option is often enough, isn't it? Like --jvm 11, --scala-js, or --scala 2.13.

lwronski · 2021-09-27T08:09:21Z

website/src/components/features.js

+        If you want to use older <b>version of Scala</b> or
+        run your code in <b>JS</b> or <b>Native</b> environments we've got you covered.
+        <br/>
+        <i>some additional <a href="TODO?">setup</a> may be required for JS and Native</i>


For scalaJs, the Node is required - https://github.com/VirtuslabRnD/scala-cli-features/issues/6

Could you add documentation what and how should be installed to js section in the documentation and link it here? Do we need any specific setup for native?

alexarchambault · 2021-09-27T08:32:31Z

The monospaced font everywhere makes it quite hard to read the descriptions, to me. It's fine for titles / headers, but I'm not sure for whole paragraphs.

alexarchambault · 2021-09-27T08:34:54Z

Maybe we should agree on a precise convention to write Scala CLI. To me, when referring to the command itself, I write scala-cli (usually as code), and when referring to the project, I write Scala CLI (in two words, with Scala capitalized, and CLI in upper case).

alexarchambault · 2021-09-27T08:36:51Z

Total NIT: I'm wondering how doable it would be to have two versions of the terminal GIFs, one for dark mode, one for light mode.

README.md

website/docusaurus.config.js

website/src/components/basicInstall.js

alexarchambault · 2021-09-27T08:52:04Z

website/src/components/features.js

+      <p>
+        scala-cli is built on top of coursier
+        <br/>
+        This allow us to manage Scala versions, dependencies and JVMs so you can test your code in different environments by changing single option.


One option is often enough, isn't it? Like --jvm 11, --scala-js, or --scala 2.13.

website/src/components/features.js

alexarchambault · 2021-09-27T09:00:15Z

website/src/pages/index.js

+
+              <p>Scala-cli does not require any configuration file and all in-file configuration can be overridden by command-line.</p>
+
+              <p>No additional installation or setup of enviroment (like specific CWD) required.</p>


What do you mean by "specific CWD"?

specific current working directory like whit sbt

alexarchambault · 2021-09-27T09:07:42Z

@lwronski FYI, the CI error seems legit:

[39/39] packager.run 
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 28
	at net.sf.image4j.codec.ico.ICOEncoder.writeAndBitmap(ICOEncoder.java:352)
	at net.sf.image4j.codec.ico.ICOEncoder.write(ICOEncoder.java:219)
	at net.sf.image4j.codec.ico.ICOEncoder.write(ICOEncoder.java:120)
	at net.sf.image4j.codec.ico.ICOEncoder.write(ICOEncoder.java:106)
	at net.sf.image4j.codec.ico.ICOEncoder.write(ICOEncoder.java:41)
	at packager.windows.DefaultImageResizer$.generateIcon(DefaultImageResizer.scala:18)
	at packager.windows.WindowsPackage.$anonfun$build$2(WindowsPackage.scala:17)
	at scala.Option.map(Option.scala:242)
	at packager.windows.WindowsPackage.$anonfun$build$1(WindowsPackage.scala:17)
	at scala.Option.flatMap(Option.scala:283)
	at packager.windows.WindowsPackage.build(WindowsPackage.scala:16)
	at packager.cli.commands.Build$.run(Build.scala:52)
	at packager.cli.commands.Build$.run(Build.scala:15)
	at caseapp.core.app.CaseApp.main(CaseApp.scala:135)
	at caseapp.core.app.CommandsEntryPoint.main(CommandsEntryPoint.scala:112)
	at packager.cli.PackagerCli.main(PackagerCli.scala)

(originates from the new logo files?)

MarcinAman · 2021-09-27T11:21:44Z

I think i am lacking some form of definition what is a simple project? Without an oral explanation from Krzysiek it is super hard to deduce what we call simple. Does simple mean only 1 file? Or maybe 1 package / module? Is using scala-js / native also considered simple?

in fact it would be super nice to have this definition somewhere on the index page. Maybe an asterisk with anchor link would do? Or even a paragraph just for this

romanowski · 2021-09-28T07:14:48Z

@alexarchambault I unified how we use scala-cli and Scala CLI and changed the font in the body of the paragraphs.

As for the terminal, we probably need to use something a bit better than manually recording gifs (like asci-cinema) and then we can play with backgrounds etc. We need to update the content of the gifs anyway.

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com> Co-authored-by: Łukasz Wroński <46607934+lwronski@users.noreply.github.com>

Simple projects -> single-module projects Unifing naming od Scala CLI Add border to gifs and images detect windows automatically.

romanowski requested a review from alexarchambault September 25, 2021 00:21

romanowski force-pushed the new-landing branch from 1a986f0 to e1c17ce Compare September 25, 2021 00:23

lwronski reviewed Sep 27, 2021

View reviewed changes

alexarchambault reviewed Sep 27, 2021

View reviewed changes

lwronski mentioned this pull request Sep 27, 2021

Fix - resizing logo.ico VirtusLab/scala-packager#13

Merged

romanowski force-pushed the new-landing branch from a9c2e28 to 1a271e7 Compare September 28, 2021 16:27

romanowski and others added 4 commits September 29, 2021 17:31

Refactor landing page and add pages for each usecase.

23d6102

Apply suggestions from code review

482770e

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com> Co-authored-by: Łukasz Wroński <46607934+lwronski@users.noreply.github.com>

Review feedback:

31b58b8

Simple projects -> single-module projects Unifing naming od Scala CLI Add border to gifs and images detect windows automatically.

Fix website building

a52e7cf

romanowski force-pushed the new-landing branch from 1a271e7 to a52e7cf Compare September 29, 2021 15:32

Update logo and change site url

a2305ea

romanowski merged commit f9a380a into VirtusLab:master Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor landing page and add pages for each usecase. #151

Refactor landing page and add pages for each usecase. #151

romanowski commented Sep 25, 2021

lwronski Sep 27, 2021

alexarchambault Sep 27, 2021

lwronski Sep 27, 2021

romanowski Sep 28, 2021

alexarchambault commented Sep 27, 2021

alexarchambault commented Sep 27, 2021

alexarchambault commented Sep 27, 2021 •

edited

Loading

alexarchambault Sep 27, 2021

alexarchambault Sep 27, 2021

romanowski Sep 28, 2021

alexarchambault commented Sep 27, 2021

MarcinAman commented Sep 27, 2021

romanowski commented Sep 28, 2021


		<p>Scala-cli does not require any configuration file and all in-file configuration can be overridden by command-line.</p>

		<p>No additional installation or setup of enviroment (like specific CWD) required.</p>

Refactor landing page and add pages for each usecase. #151

Refactor landing page and add pages for each usecase. #151

Conversation

romanowski commented Sep 25, 2021

lwronski Sep 27, 2021

Choose a reason for hiding this comment

alexarchambault Sep 27, 2021

Choose a reason for hiding this comment

lwronski Sep 27, 2021

Choose a reason for hiding this comment

romanowski Sep 28, 2021

Choose a reason for hiding this comment

alexarchambault commented Sep 27, 2021

alexarchambault commented Sep 27, 2021

alexarchambault commented Sep 27, 2021 • edited Loading

alexarchambault Sep 27, 2021

Choose a reason for hiding this comment

alexarchambault Sep 27, 2021

Choose a reason for hiding this comment

romanowski Sep 28, 2021

Choose a reason for hiding this comment

alexarchambault commented Sep 27, 2021

MarcinAman commented Sep 27, 2021

romanowski commented Sep 28, 2021

alexarchambault commented Sep 27, 2021 •

edited

Loading