Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to update only to stable version #1634

Merged
merged 1 commit into from Dec 5, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Dec 2, 2022

No description provided.

@lwronski lwronski marked this pull request as ready for review December 2, 2022 09:22
@alexarchambault
Copy link
Contributor

alexarchambault commented Dec 2, 2022

I think a way to test would be to create a mock repository with both stable and unstable versions, and check that the diagnostics suggest the right version updates. Something along those lines

val inputs = TestInputs(
  os.rel / "repo" / "test-org" / "test-name-1" / "maven-metadata.xml" ->
    """// see https://repo1.maven.org/maven2/io/get-coursier/scalapy-echo_2.13/maven-metadata.xml for an example …
      |""".stripMargin,
  os.rel / "repo" / "test-org" / "test-name-1" / "0.1.0" / "test-name-1-0.1.0.pom" ->
    """// see https://repo1.maven.org/maven2/io/get-coursier/scalapy-echo_2.13/1.0.6/scalapy-echo_2.13-1.0.6.pom for an example …
      |""".stripMargin,
  os.rel / "repo" / "test-org" / "test-name-1" / "0.1.1-M1" / "test-name-1-0.1.1-M1.pom" ->
    """// see https://repo1.maven.org/maven2/io/get-coursier/scalapy-echo_2.13/1.0.6/scalapy-echo_2.13-1.0.6.pom for an example …
      |""".stripMargin,
  // etc.
)

inputs.fromRoot { root =>
  // use (root / "repo").toNIO.toUri.toASCIIString as a repo
}

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lwronski lwronski force-pushed the fix-pre-release-version branch 2 times, most recently from 486b55e to 5aa35ae Compare December 5, 2022 11:33
@lwronski lwronski merged commit fdf6fa5 into VirtusLab:main Dec 5, 2022
@Gedochao Gedochao added the bug Something isn't working label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants