Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - merge extra repos with resolve.repositories #1643

Merged
merged 1 commit into from Dec 5, 2022
Merged

Fix - merge extra repos with resolve.repositories #1643

merged 1 commit into from Dec 5, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Dec 5, 2022

Fix fetching external binary in M1 - fail.

withRepositories only sets repositories from params.extraRepos but we should merge the default repositories from courier with extraRepos, so I'll use addRepositories.

tgodzik
tgodzik approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lwronski lwronski merged commit 778ce6c into VirtusLab:main Dec 5, 2022
@Gedochao Gedochao added the internal Internal or build-related changes label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
internal Internal or build-related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lwronski @tgodzik @Gedochao