Turn cookbook recepies into examples #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs_checker/check.scala
Outdated
| @@ -1,5 +1,6 @@ | |||
| // using scala 3.0.2 | |||
| // using "org.scalameta::munit:0.7.29" | |||
| // using com.lihaoyi:ammonite-ops_2.13:2.4.0 | |||
There was a problem hiding this comment.
Wouldn't os-lib (com.lihaoyi::os-lib:0.7.5) be enough? Ammonite-ops is more or less deprecated IIRC.
There was a problem hiding this comment.
I just pick a random lib, I will change that
romanowski
force-pushed
the
create-examples
branch
4 times, most recently
from
002ba9d
to
591d2a5
Compare
romanowski
force-pushed
the
create-examples
branch
from
591d2a5
to
d7e0fc9
Compare
lwronski
reviewed
Oct 7, 2021
docs_checker/check.scala
Outdated
| catch | ||
| case e: Throwable => | ||
| e.printStackTrace() | ||
| Seq(TestCase(path, Some(e))) | ||
|
|
||
| def checkFile(file: Path) = | ||
| def ammPath(p: Path) = os.Path(p.toAbsolutePath) |
There was a problem hiding this comment.
I think, this method can be removed if you migrate from Java - Paths.* to os.lib.
docs_checker/check.scala
Outdated
|
|
||
| val fakeLineMarker = "//fakeline" | ||
|
|
||
| def checkFile(file: Path, dest: Option[Path]) = | ||
| val content = Files.lines(file).iterator.asScala.toList |
There was a problem hiding this comment.
Suggested change
| val content = Files.lines(file).iterator.asScala.toList | |
| val content = os.read.lines(file) |
but, you have to replace Path to os.Path
romanowski
force-pushed
the
create-examples
branch
2 times, most recently
from
953c9fb
to
8c72bad
Compare
- add `fail` flag to make sure that command fail - skip frontmatter in generated readmefiles - migrate to os-lib
romanowski
force-pushed
the
create-examples
branch
from
8c72bad
to
aa79fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.