Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build native launcher for linux aarch64 #1703

Merged
merged 1 commit into from Dec 19, 2022

Conversation

lwronski
Copy link
Contributor

No description provided.

@lwronski lwronski force-pushed the linux-arm64 branch 2 times, most recently from 4fc6e3d to 3a0bf64 Compare December 18, 2022 14:41
@lwronski lwronski marked this pull request as ready for review December 18, 2022 18:11
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try manually running the integration tests on a Linux/ARM64 machine? Just so that we have an idea if it works ok in most cases, or if it's just broken there?

.github/workflows/ci.yml Show resolved Hide resolved
@lwronski
Copy link
Contributor Author

Did you try manually running the integration tests on a Linux/ARM64 machine? Just so that we have an idea if it works ok in most cases, or if it's just broken there?

I used generated launcher and run some tests such as(RunTestsDefault, BspTestsDefault, CompileTestsDefault) in Ubuntu with arm64 architecture and it works.

@mkurz
Copy link
Contributor

mkurz commented Dec 21, 2022

Doesn't work for me, please see #1714

@Gedochao Gedochao added enhancement New feature or request installation Everything related to installing the CLI itself labels Dec 22, 2022
@mkurz
Copy link
Contributor

mkurz commented Dec 23, 2022

This binary does not work for all aarch64 kernels out there. Most of the aarch64 Linux kernel will have a page size of 4k, which this binary is compatible with, but if a kernel runs another page size like 64k or, like in my case, 16k, this binary will not work.
See coursier/coursier#2636 (comment)

@mkurz
Copy link
Contributor

mkurz commented Jan 13, 2023

So this QEMU thing is quite slow, seems like James Ward came up with a faster approach: https://twitter.com/_JamesWard/status/1613201502469750785 (I didn't read it, just posting so you are aware and might like it)

@lwronski
Copy link
Contributor Author

So this QEMU thing is quite slow, seems like James Ward came up with a faster approach: https://twitter.com/_JamesWard/status/1613201502469750785 (I didn't read it, just posting so you are aware and might like it)

Thanks for the suggestions. I did a slightly different approach, used an actual runner that scala-cli builds macos-m1 launchers and there I run build the aarch64 linux launcher using docker. I reduced the build time to 20 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installation Everything related to installing the CLI itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants