Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download aarch64 artifact in launcher script #1745

Merged
merged 1 commit into from Jan 4, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Jan 3, 2023

Follow-up to #1726 / #1714.
Now that scala-ci has aarch64 support since v0.1.19 the launcher script should also download the correct artifact.

This pull request does more or less the same we do in the sbt script here, just since a couple of hours actually 馃槈 (sbt/sbt#7110)

Currently on my Linux aarch64 machine:

$ ./scala-cli.sh 
Downloading https://github.com/VirtusLab/scala-cli/releases/download/v0.1.19/scala-cli-x86_64-pc-linux.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 30.6M  100 30.6M    0     0  6166k      0  0:00:05  0:00:05 --:--:-- 8667k

With this pull request:

$ ./scala-cli.sh 
Downloading https://github.com/VirtusLab/scala-cli/releases/download/v0.1.19/scala-cli-aarch64-pc-linux.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 30.3M  100 30.3M    0     0  8329k      0  0:00:03  0:00:03 --:--:-- 10.0M

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mkurz Thanks!

@lwronski lwronski merged commit e818e9d into VirtusLab:main Jan 4, 2023
@mkurz mkurz deleted the aarch64_script branch January 4, 2023 14:41
@Gedochao Gedochao added the installation Everything related to installing the CLI itself label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Everything related to installing the CLI itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants