Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate OS package for aarch64 and let sdkman know #1748

Merged
merged 1 commit into from Jan 13, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Jan 4, 2023

sdkman doesn't know about the aarch64/arm64 binary yet 馃槩
This is what I get on my aarch64 Linux:

$ sdk install scalacli

Stop! scalacli 0.1.19 is not available. Possible causes:
 * 0.1.19 is an invalid version
 * scalacli binaries are incompatible with your platform
 * scalacli has not been released yet

Tip: see all available versions for your platform:

  $ sdk list scalacli
$ sdk list scalacli
================================================================================
Available Scalacli Versions
================================================================================
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                

================================================================================
+ - local version
* - installed
> - currently in use
================================================================================

@mkurz mkurz force-pushed the generate_os_package_aarch64 branch from 5799132 to 71807b8 Compare January 12, 2023 07:26
@mkurz
Copy link
Contributor Author

mkurz commented Jan 12, 2023

@lwronski Finished, it should work now. Here you can see the artifacts generated also with the sdk packages for aarch64: https://github.com/VirtusLab/scala-cli/actions/runs/3897030762 This was the last run, I just squashed the commit now and removed added back the if: github.event_name == 'push', so the generate-linux-arm64-native-launcher doesn't run for PRs, because it takes ages.
I tested the artifacts of the sdk aarch64 package and it works now.

Should be ready to merge.

@mkurz mkurz requested a review from lwronski January 12, 2023 08:36
@mkurz
Copy link
Contributor Author

mkurz commented Jan 12, 2023

CI is green now as well.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your works! In the next week wa plan the next release of scala-cli, so we can verify your PR in release.

.github/workflows/ci.yml Show resolved Hide resolved
@lwronski lwronski merged commit d1cc76b into VirtusLab:main Jan 13, 2023
@mkurz mkurz deleted the generate_os_package_aarch64 branch January 13, 2023 14:25
@Gedochao Gedochao added the installation Everything related to installing the CLI itself label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Everything related to installing the CLI itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants