New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ammonite imports support #1787
Merged
MaciejG604
merged 3 commits into
VirtusLab:main
from
MaciejG604:remove-ammonite-imports-support
Jan 20, 2023
Merged
Remove ammonite imports support #1787
MaciejG604
merged 3 commits into
VirtusLab:main
from
MaciejG604:remove-ammonite-imports-support
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
from
January 18, 2023 12:34
45ff80c
to
24a359e
Compare
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
from
January 18, 2023 13:31
24a359e
to
deee3aa
Compare
lwronski
reviewed
Jan 18, 2023
modules/build/src/main/scala/scala/build/preprocessing/ScalaPreprocessor.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
from
January 18, 2023 14:42
deee3aa
to
22631ea
Compare
This was
linked to
issues
Jan 18, 2023
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
from
January 18, 2023 15:23
22631ea
to
dc429e9
Compare
lwronski
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
3 times, most recently
from
January 19, 2023 13:04
001825a
to
7a3695d
Compare
Gedochao
approved these changes
Jan 20, 2023
MaciejG604
force-pushed
the
remove-ammonite-imports-support
branch
from
January 20, 2023 11:21
7a3695d
to
35e10b3
Compare
Gedochao
added
SIP-46
All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Ammonite
labels
Jan 24, 2023
tgodzik
pushed a commit
to tgodzik/scala-cli
that referenced
this pull request
Feb 13, 2023
* Remove support for ammonite scripts imports, add error with actionable diagnostics * Clean up documentation about and imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1678