Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ammonite imports support #1787

Merged
merged 3 commits into from Jan 20, 2023

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Jan 17, 2023

Resolves #1678

@MaciejG604 MaciejG604 force-pushed the remove-ammonite-imports-support branch from 45ff80c to 24a359e Compare January 18, 2023 12:34
@MaciejG604 MaciejG604 marked this pull request as ready for review January 18, 2023 12:35
@MaciejG604 MaciejG604 self-assigned this Jan 18, 2023
@MaciejG604 MaciejG604 force-pushed the remove-ammonite-imports-support branch from 24a359e to deee3aa Compare January 18, 2023 13:31
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 force-pushed the remove-ammonite-imports-support branch 3 times, most recently from 001825a to 7a3695d Compare January 19, 2023 13:04
@MaciejG604 MaciejG604 force-pushed the remove-ammonite-imports-support branch from 7a3695d to 35e10b3 Compare January 20, 2023 11:21
@MaciejG604 MaciejG604 merged commit f4528d9 into VirtusLab:main Jan 20, 2023
@Gedochao Gedochao added SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. Ammonite labels Jan 24, 2023
tgodzik pushed a commit to tgodzik/scala-cli that referenced this pull request Feb 13, 2023
* Remove support for ammonite scripts imports, add error with actionable diagnostics

* Clean up documentation about  and  imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ammonite SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
3 participants