Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid subcommand arg #1811

Merged
merged 5 commits into from Feb 14, 2023
Merged

Invalid subcommand arg #1811

merged 5 commits into from Feb 14, 2023

Conversation

MaciejG604
Copy link
Contributor

No description provided.

@Gedochao
Copy link
Contributor

scala.cli.integration.SipScalaTests.test directories command when run as* needs to be adjusted, as it relies on the old error message

@MaciejG604 MaciejG604 self-assigned this Jan 28, 2023
@MaciejG604 MaciejG604 force-pushed the invalid-subcommand-arg branch 3 times, most recently from 7eb6408 to e69cea8 Compare January 31, 2023 09:06
@MaciejG604 MaciejG604 force-pushed the invalid-subcommand-arg branch 5 times, most recently from 3ba4415 to c508295 Compare February 6, 2023 13:41
@MaciejG604 MaciejG604 linked an issue Feb 7, 2023 that may be closed by this pull request
Show help document if for the invalid subcommand #1240
Closed
@MaciejG604 MaciejG604 force-pushed the invalid-subcommand-arg branch 7 times, most recently from d68159c to d8a69c5 Compare February 13, 2023 11:12
@MaciejG604 MaciejG604 force-pushed the invalid-subcommand-arg branch 3 times, most recently from 0b4b876 to 8b69ff1 Compare February 14, 2023 08:14
Gedochao
Gedochao reviewed Feb 14, 2023
View reviewed changes
modules/build/src/main/scala/scala/build/input/ScalaCliInvokeData.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/ScalaCliInvokeData.scala Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/Inputs.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/Inputs.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/Inputs.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/Inputs.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/input/Inputs.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/commands/shared/SharedOptions.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/commands/run/Run.scala Outdated Show resolved Hide resolved
website/docs/guides/shebang.md Outdated Show resolved Hide resolved
@MaciejG604 MaciejG604 merged commit 816f91b into VirtusLab:main Feb 14, 2023
@Gedochao Gedochao added UX SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. help All the issues related to improving help outputs labels Feb 15, 2023
@MaciejG604 MaciejG604 deleted the invalid-subcommand-arg branch February 21, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao left review comments

@lwronski lwronski lwronski approved these changes

Assignees

@MaciejG604 MaciejG604

Labels
help All the issues related to improving help outputs SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show help document if for the invalid subcommand
3 participants
@MaciejG604 @Gedochao @lwronski