Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blooprifle: report exit code in exception #1844

Merged

Conversation

Flowdalic
Copy link
Contributor

To help debugging, the failure code is now part of the exception in case the bloop server failed to start.

I've worked on this during debugging #1843. Turns out, knowing the exit code was not really helpful in this case. However, I believe that it is never wrong to load the exception with it.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flowdalic Thanks for your contribution! LGTM

The error in CI is unrelated to your changes, and the Scala-CLI team will fix it soon.

@Gedochao
Copy link
Contributor

@Flowdalic, the CI should pass if you rebase your branch with the newest changes from main.
The same applies to #1845

@Flowdalic Flowdalic force-pushed the blooprifle-report-exit-code-in-exception branch from 50620c7 to cea3501 Compare February 10, 2023 08:38
@Gedochao
Copy link
Contributor

Gedochao commented Feb 10, 2023

@Flowdalic it seems the following tests are failing and will need to be adjusted.

integration.test.test 3 tests failed: 
  scala.cli.integration.BloopTests.invalid bloop options passed via cli cause bloop start failure 
  scala.cli.integration.BloopTests.invalid bloop options passed via global bloop config json file cause bloop start failure 
  scala.cli.integration.UpdateTests.updating dummy scala-cli using update command 
Error: Process completed with exit code 1.

I suspect scala.cli.integration.UpdateTests.updating dummy scala-cli using update command is an intermittent connection failure, but the other 2 will need code adjustments.

BTW. let me know if you'll have trouble to find the time to fix this, in which case either me or someone else from the maintenance team will have a look.

To help debugging, the failure code is now part of the exception in
case the bloop server failed to start.
@Flowdalic Flowdalic force-pushed the blooprifle-report-exit-code-in-exception branch from cea3501 to 0f10f91 Compare February 10, 2023 11:27
@lwronski lwronski enabled auto-merge (squash) February 10, 2023 12:32
@lwronski lwronski merged commit 0f508d9 into VirtusLab:main Feb 10, 2023
@Flowdalic Flowdalic deleted the blooprifle-report-exit-code-in-exception branch February 11, 2023 12:12
tgodzik pushed a commit to tgodzik/scala-cli that referenced this pull request Feb 13, 2023
To help debugging, the failure code is now part of the exception in
case the bloop server failed to start.
@Gedochao Gedochao added the internal Internal or build-related changes label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants