Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify features based on binary name #1849

Merged
merged 5 commits into from Feb 16, 2023
Merged

Conversation

lwronski
Copy link
Contributor

I'd like to highlight the implications of this change implying the usage of scala-cli:

  1. The non sip commands (package and export) have stoped working with the scala-cli launcher. Running these commands will now result in an error.
package is not a scala-cli sub-command and it is not a valid path to an input file or directory
                Try 'scala-cli--help' to see the list of available sub-commands and options

so this warning should be extended to add info - that to avoiding this error, users should either use the --power option or set power to true globally using the scala-cli config power true command.

  1. https://github.com/VirtusLab/scala-cli-setup - should be added a configuration that enables the power functionalities in scala-cli, something like this:
    - uses: VirtusLab/scala-cli-setup@main
      with:
        power: true
  1. Running docker scala-cli image will require passing --powerwith non sip commands when executing this image:
docker run virtuslab/scala-cli:latest --power package .

or we can publish docker image with enabling power by default.

Fixes #1824

@lwronski lwronski added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Feb 16, 2023
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwronski lwronski merged commit 37f400b into VirtusLab:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't modify features based on binary name
2 participants