Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIT Use enums for help groups and help command groups #1880

Merged
merged 1 commit into from Feb 24, 2023

Conversation

Gedochao
Copy link
Contributor

Follow-up for #1872 (comment)

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could we avoid backticked cases?

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for indulging my OCD

@Gedochao Gedochao merged commit e689734 into VirtusLab:main Feb 24, 2023
@Gedochao Gedochao deleted the post-shorter-help-cleanup branch February 24, 2023 07:08
@Gedochao Gedochao added the internal Internal or build-related changes label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants