Prevent null exception, throw exception on secret key / password missing #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
publish-null-exception
branch
from
88acbed
to
0ff1cdf
Compare
MaciejG604
force-pushed
the
publish-null-exception
branch
from
0ff1cdf
to
5e85ac0
Compare
Gedochao
reviewed
Mar 6, 2023
modules/integration/src/test/scala/scala/cli/integration/PublishTestDefinitions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
publish-null-exception
branch
from
5e85ac0
to
3088281
Compare
MaciejG604
force-pushed
the
publish-null-exception
branch
from
b20877b
to
de97fa4
Compare
modules/integration/src/test/scala/scala/cli/integration/PublishTestDefinitions.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
publish-null-exception
branch
2 times, most recently
from
d77c80a
to
a809a73
Compare
MaciejG604
force-pushed
the
publish-null-exception
branch
from
a809a73
to
6050d29
Compare
|
The mechanism of PGP singing files with BouncyCastle using no secret key password is unstable with native launcher. I've excluded the test for it from native launcher tests, but it should be fixed. I've created a follow-up issue: #1913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
scala-cli publishwith--secret-keybut no value for--secret-key-passwordan ambiguous error is presented to the user due tonullbeing referenced (line 888 in old version). This should fix the exception and also warn users if one of the values is missing.Also fixes #1899
Follow-up to #1432