Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nativeLto options in command line and using directives #1964

Merged
merged 4 commits into from Mar 28, 2023
Merged

Add support for nativeLto options in command line and using directives #1964

merged 4 commits into from Mar 28, 2023

Conversation

lwronski
Copy link
Contributor

Fixes #1951.

I added support for passing the --native-lto option via the command line:

scala-cli Hello.scala --native --native-lto thin

or via using directives:

$ cat Hello.scala
//> using nativeLto "thin"

object Main extends App {
  println("Hello2")
}

@lwronski lwronski force-pushed the native-lto branch 2 times, most recently from ffaf38b to 191910a Compare March 27, 2023 16:25
@lwronski lwronski marked this pull request as ready for review March 27, 2023 20:51
Gedochao
Gedochao approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

website/docs/reference/cli-options.md Show resolved Hide resolved
@lwronski lwronski merged commit a30fa20 into VirtusLab:main Mar 28, 2023
37 checks passed
@Gedochao Gedochao added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scala Native should allow nativeLTO option
2 participants
@lwronski @Gedochao