Properly handle pgp keychains generated by Scala CLI #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
properly-handle-pgp-keychains-continuation
branch
2 times, most recently
from
65c89c9
to
68a05fd
Compare
MaciejG604
changed the title
MaciejG604
force-pushed
the
properly-handle-pgp-keychains-continuation
branch
2 times, most recently
from
f436ae0
to
ce80ff9
Compare
Gedochao
reviewed
Apr 3, 2023
modules/cli/src/main/scala/scala/cli/commands/config/Config.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/config/ConfigOptions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/ConfigTests.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/checks/PgpSecretKeyCheck.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/checks/PgpSecretKeyCheck.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
properly-handle-pgp-keychains-continuation
branch
3 times, most recently
from
c4106d8
to
fbc4a95
Compare
…s leaking to publish-conf.scala
MaciejG604
force-pushed
the
properly-handle-pgp-keychains-continuation
branch
from
fbc4a95
to
a0570a0
Compare
lwronski
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is illogical to encrypt the private key (it's actually a keychain) with a password just to keep them together in the same config file. We should require explicitly setting a password or explicitly opting for
noneorrandom(althoughrandomis the least useful if you think about it, maybe for CI).The only possible problem with my solution is that this introduces some new option values (random and none), that the user would need to know how to use.