Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print the spread directives warning if there's only a single file per scope #1988

Merged
merged 1 commit into from Apr 5, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 31, 2023

Context: #1729

@Gedochao Gedochao changed the title tweak warnings about directives spread across multiple inputs tweak warnings about directives spread across multiple inputs [WIP] Mar 31, 2023
@Gedochao Gedochao changed the title tweak warnings about directives spread across multiple inputs [WIP] [WIP] tweak warnings about directives spread across multiple inputs Mar 31, 2023
@Gedochao Gedochao force-pushed the spread-directives-warnings-fixes branch 2 times, most recently from 58c7d02 to c835fb3 Compare April 3, 2023 08:42
@Gedochao Gedochao changed the title [WIP] tweak warnings about directives spread across multiple inputs Don't print the spread directives warning if there's only a single file per scope Apr 5, 2023
@Gedochao Gedochao marked this pull request as ready for review April 5, 2023 08:51
@Gedochao Gedochao force-pushed the spread-directives-warnings-fixes branch from c835fb3 to 9a5ba7d Compare April 5, 2023 11:42
@Gedochao Gedochao requested a review from lwronski April 5, 2023 11:42
@Gedochao Gedochao force-pushed the spread-directives-warnings-fixes branch from 9a5ba7d to aa94280 Compare April 5, 2023 11:55
@Gedochao Gedochao merged commit d3fd3dc into VirtusLab:main Apr 5, 2023
37 checks passed
@Gedochao Gedochao deleted the spread-directives-warnings-fixes branch April 5, 2023 13:43
@Gedochao Gedochao added bug Something isn't working UX labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants