New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --as-jar option #2028
Merged
Merged
Add --as-jar option #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
as-jar
branch
2 times, most recently
from
April 11, 2023 10:58
8d8bd23
to
78c9da2
Compare
alexarchambault
force-pushed
the
as-jar
branch
2 times, most recently
from
April 12, 2023 09:23
75415b5
to
7c9708c
Compare
lwronski
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the documentation? I think it could be added near the --print-class-path
section.
Other than that, LGTM.
alexarchambault
force-pushed
the
as-jar
branch
2 times, most recently
from
April 12, 2023 14:22
b9f5fed
to
69c0e24
Compare
So that the next commit diff is easier to read. The commit here really only changes indentation of some blocks, nothing more.
lwronski
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Putting the project byte code in the class path as a JAR, in the compile / run / test / repl commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2016
This adds an
--as-jar
option to thecompile
/run
/test
/repl
commands, that puts the project byte code as a JAR in the class path, rather than as a directory, which is useful in contexts where JARs are required.