Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --as-jar option #2028

Merged
merged 5 commits into from Apr 13, 2023
Merged

Add --as-jar option #2028

merged 5 commits into from Apr 13, 2023

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Apr 11, 2023

Fixes #2016

This adds an --as-jar option to the compile / run / test / repl commands, that puts the project byte code as a JAR in the class path, rather than as a directory, which is useful in contexts where JARs are required.

@alexarchambault alexarchambault marked this pull request as ready for review April 11, 2023 10:58
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation? I think it could be added near the --print-class-path section.
Other than that, LGTM.

So that the next commit diff is easier to read.

The commit here really only changes indentation of some blocks, nothing more.
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Putting the project byte code in the class path as a JAR, in the
compile / run / test / repl commands
@alexarchambault alexarchambault merged commit bd9fa79 into VirtusLab:main Apr 13, 2023
37 checks passed
@alexarchambault alexarchambault deleted the as-jar branch April 13, 2023 10:25
@Gedochao Gedochao added the enhancement New feature or request label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --print-class-path-as-jars option to the compile command
3 participants