improvement: Bump using directives to 1.0.0 #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
bump-using-directives
branch
2 times, most recently
from
c925574
to
22b5c99
Compare
|
I updated some of the tests to use the new syntax, not sure if there is a new to do it for everything, but I would write new tests with the new syntax. |
tgodzik
force-pushed
the
bump-using-directives
branch
2 times, most recently
from
a69b99c
to
72e7a5c
Compare
This includes the changes to simplify using directives: - remove the possibility of nesting from API - allow to omit commas in lists of values - don't allow multiline comments - remove multiline strings - remove require and @require syntax support - allow values without quotes - remove @using - remove multiline directives
tgodzik
force-pushed
the
bump-using-directives
branch
from
db4eea4
to
85fec0f
Compare
tgodzik
force-pushed
the
bump-using-directives
branch
from
85fec0f
to
658a8b9
Compare
Gedochao
approved these changes
May 8, 2023
lwronski
reviewed
May 8, 2023
modules/build/src/main/scala/scala/build/preprocessing/ExtractedDirectives.scala
Outdated
Show resolved
Hide resolved
lwronski
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes to simplify using directives:
Fixes #2049
Fixes #1954