Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compile-only dependencies and class path expansion (properties, globs) #2115

Closed
wants to merge 4 commits into from
Closed

Add support for compile-only dependencies and class path expansion (properties, globs) #2115

wants to merge 4 commits into from

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented May 11, 2023 •
edited

I've been needing these features in some of the things I'm working on, so I quickly hacked that

@alexarchambault alexarchambault force-pushed the compile-only-deps branch 2 times, most recently from 63678f1 to ba8af08 Compare May 11, 2023 17:12
@alexarchambault alexarchambault marked this pull request as draft May 11, 2023 17:12
@alexarchambault
Copy link
Contributor Author

I guess the last two commits need a bit of doc…

@alexarchambault alexarchambault changed the title Add support for compile-only dependencies Add support for compile-only dependencies and class path expansion (properties, globs) May 11, 2023
Gedochao
Gedochao reviewed May 12, 2023
View reviewed changes
modules/options/src/main/scala/scala/build/Artifacts.scala Outdated
@@ -356,14 +396,19 @@ object Artifacts {
.map(_.flatten)
}

coursier.Artifacts()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

modules/options/src/main/scala/scala/build/Artifacts.scala
res
}

private def fetchKeepFetcher(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is a bit confusing, I think... some scaladocs would help, maybe 🤔
It's hard to get around between fetch, fetch0 and fetchKeepFetcher...

modules/cli/src/main/scala/scala/cli/exportCmd/MillProjectDescriptor.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want some export test for compile-only dependencies, for both Mill & SBT

@Gedochao Gedochao linked an issue May 12, 2023 that may be closed by this pull request
Add support for compile-only dependencies (aka "provided" dependencies) #817
Closed
@alexarchambault alexarchambault linked an issue May 12, 2023 that may be closed by this pull request
Accept wildcards in --extra-jars #2027
Open
@alexarchambault
Split --extra-jar and -classpath options handling
408b47f 
So that the handling of --extra-jar can be refined in subsequent commits,
while we can retain some legacy features in -classpath
@alexarchambault
Expand class path arguments with class-path-util
f8f3c84 
So that properties and some globs are expanded. This makes things like
```
//> using jars "${spark.home}/jars/*:${spark.dist.classpath}"
```
work for example (provided users set the `spark.home` and
`spark.dist.classpath` properties)
@Gedochao
Copy link
Contributor

@alexarchambault What's the current status of this PR? Any plans to finish it in the near future?

@alexarchambault
Copy link
Contributor Author

What's the current status of this PR? Any plans to finish it in the near future?

I do, likely in the coming weeks, I'd say

@lwronski
Copy link
Contributor

What's the current status of this PR? Any plans to finish it in the near future?

I do, likely in the coming weeks, I'd say

@alexarchambault Hi Alex, I hope you're doing well. I'm just checking to see if you have time to finish this PR soon. If you're busy, I can help to finish it, especially to add support for the compile-only dependencies. Let me know your preference.

@Gedochao
Copy link
Contributor

Gedochao commented Oct 5, 2023 •
edited

Closing this, as it seems to have been largely delivered already by @lwronski in #2299 (#817).
The remaining requirements are already tracked separately under #2027.

@Gedochao Gedochao closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept wildcards in --extra-jars Add support for compile-only dependencies (aka "provided" dependencies)
3 participants
@alexarchambault @Gedochao @lwronski