Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the --source-jar option & add corresponding using directives #2120

Merged
merged 7 commits into from May 18, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented May 16, 2023

Fixes #2097

It turns out the --source-jar command line option was implemented, but not at all passed to the build (and thus, non-functioning).
I fixed it, added corresponding directives and added some tests & docs.

//> using sourceJar path/to/jar-sources

Additionally, the code now assumes any JARs with the *-sources.jar name suffix are assumed to be sources JARs, and are treated appropriately (along with a warning).

scala-cli . --extra-jar '/path/to/custom-sources.jar'
# [warn] Jars with the *-sources.jar name suffix are assumed to be source jars.
# The following jars were assumed to be source jars and will be treated as such: /path/to/custom-sources.jar

@Gedochao Gedochao added bug Something isn't working enhancement New feature or request labels May 16, 2023
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao enabled auto-merge May 18, 2023 05:57
@Gedochao Gedochao merged commit aac2fa1 into VirtusLab:main May 18, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing using directive for handling source jars
3 participants