Add cookbook for docker #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
reviewed
Oct 14, 2021
|
|
||
| The following command will generate `hello-docker` image with `latest` tag: | ||
| ```bash ignore | ||
| scala-cli package --docker HelloWorld.scala --docker-image-repository hello-docker |
There was a problem hiding this comment.
Why do we need to ignore this commands?
There was a problem hiding this comment.
You're right, we should check these code snippets with the docs-checker. I fixed it.
I only skip checking for building docker image with scala-native, because for now, we support it only on Linux environments. It would be a pain if docs-checker failed every time on macOS.
romanowski
reviewed
Oct 14, 2021
|
|
||
| Passing `--docker` to the `package` sub-command generates a docker image. The docker image name parameter `--docker-image-repository` is mandatory. | ||
|
|
||
| The following command will generate `hello-docker` image with `latest` tag: |
There was a problem hiding this comment.
Could one configure custom tag? If so I think we should add it to the guide
romanowski
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.