Fix publishing with implicit publish.version coming from a git tag
#2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
approved these changes
May 26, 2023
lwronski
approved these changes
May 26, 2023
Gedochao
force-pushed
the
fix-publish-local
branch
2 times, most recently
from
4a09c26
to
bd17cbe
Compare
Gedochao
force-pushed
the
fix-publish-local
branch
2 times, most recently
from
238ee04
to
7d7b78c
Compare
Gedochao
force-pushed
the
fix-publish-local
branch
from
7d7b78c
to
2e81fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151
Turns out we didn't have test coverage for when the published project version is implicitly read from a
gittag, and so we missed the appropriate reflection configuration to coverjgitstuff onGraalVM.