Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bsp wrapper fixes #2171

Merged
merged 4 commits into from Jun 2, 2023
Merged

Bsp wrapper fixes #2171

merged 4 commits into from Jun 2, 2023

Conversation

MaciejG604
Copy link
Contributor

Fixes #2158 and #2165

Refactored propagating the value of topWrapperLineCount into a bigger structure WrapperParams that has more information.

@MaciejG604 MaciejG604 linked an issue May 30, 2023 that may be closed by this pull request
@MaciejG604 MaciejG604 marked this pull request as draft May 30, 2023 15:35
@MaciejG604 MaciejG604 marked this pull request as ready for review May 31, 2023 10:21
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Just one question from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No semanticdb for scripts Top and bottom wrappers broken after recent changes
3 participants