Support for new command

[zetashift]

Adds a new command to scala-cli to enable creating projects through giter8.

Resolves #19

New to the scala-cli codebase, so all feedback welcome as I have no real idea if I'm heading in the right direction.
I'll add docs when the code is in a better shape!

[lwronski]

It would also be beneficial to add some integration tests. You can create a new class NewTests in integration test, similar to FmtTests.

[zetashift]

It would also be beneficial to add some integration tests. You can create a new class NewTests in integration test, similar to FmtTests.

Currently trying to add integration tests, but kinda lost in what kind of template to expect.

package scala.cli.integration

class NewTests extends ScalaCliSuite {
  
}

The scalafmt integrations seem quite straightforward, but for the giter8 dep I need some "default" scala-cli giter8 template no? And should this live on my github or can we update (for example) this one: https://github.com/VirtuslabRnD/scala-cli.g8 ?

[lwronski]

It would also be beneficial to add some integration tests. You can create a new class NewTests in integration test, similar to FmtTests.

Currently trying to add integration tests, but kinda lost in what kind of template to expect.

package scala.cli.integration

class NewTests extends ScalaCliSuite {
  
}

The scalafmt integrations seem quite straightforward, but for the giter8 dep I need some "default" scala-cli giter8 template no? And should this live on my github or can we update (for example) this one: https://github.com/VirtuslabRnD/scala-cli.g8 ?

I think it is the default repository that scala-cli wants to maintain. So let's use them in the integration test.

[zetashift]

I think it is the default repository that scala-cli wants to maintain. So let's use them in the integration test.

No idea why I couldn't find this, thank you! :D

[zetashift]

CI is reporting:

scala.cli.integration.SparkTests213:
  + run spark 3.3 standalone 9.271s
  + run spark spark-submit args 8.239s
scala.cli.integration.ExportJsonTestsDefault:
scala.cli.integration.DefaultFileTests:
1 targets failed
integration.test.test 1 tests failed: 
  scala.cli.integration.PackageTests213.simple script scala.cli.integration.PackageTests213.simple script
Error: Process completed with exit code 1.

I am quite sure I am not touching this part of the code:

scala-cli/modules/integration/src/test/scala/scala/cli/integration/PackageTestDefinitions.scala

Line 33 in 563fdd5

test("simple script") {

[lwronski]

CI is reporting:

scala.cli.integration.SparkTests213:
  + run spark 3.3 standalone 9.271s
  + run spark spark-submit args 8.239s
scala.cli.integration.ExportJsonTestsDefault:
scala.cli.integration.DefaultFileTests:
1 targets failed
integration.test.test 1 tests failed: 
  scala.cli.integration.PackageTests213.simple script scala.cli.integration.PackageTests213.simple script
Error: Process completed with exit code 1.

I am quite sure I am not touching this part of the code:

scala-cli/modules/integration/src/test/scala/scala/cli/integration/PackageTestDefinitions.scala

Line 33 in 563fdd5

test("simple script") {

Not really, it throws some timeout. I will re-run CI.

[zetashift]

Not really, it throws some timeout. I will re-run CI.

Ohhh didn't see that 🙈 , thank you :D.

[bishabosha]

does this also create the .bsp/scala-cli.json file so that IDE import works right after? - would be good to not require another step from the user

[zetashift]

does this also create the .bsp/scala-cli.json file so that IDE import works right after? - would be good to not require another step from the user

Currently the command does not do this. I don't mind adding it!
A consideration:

• There is also nothing stopping one from instantiating a g8 template that targets a sbt or mill project, so maybe that option should be a flag?

[lwronski]

does this also create the .bsp/scala-cli.json file so that IDE import works right after? - would be good to not require another step from the user

No, it doesn't generate .bsp automatically, but it would be a good idea for Scala CLI to do so. I think this idea could be implemented in a separate pull request.

[zetashift]

I think this idea could be implemented in a separate pull request.

Yeah, sounds good to me.

[lwronski]

LGTM @zetashift Thanks for your contribution

[lwronski]

I think this idea could be implemented in a separate pull request.

Yeah, sounds good to me.

To keep track of this idea, I have created an issue for it - #2230