Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline code in directives docs #2233

Merged

Conversation

izzyreal
Copy link
Contributor

@izzyreal izzyreal commented Jun 21, 2023

Backticks are missing for 2 directives.

@lwronski
Copy link
Contributor

Missing backticks are missing for 2 directives.

@izzyreal Thank you for your contribution. Please update the ObjectWrapper and Python case class for the using directives in order to generate the reference docs based on the @DirectiveUsage defined in the code. After making the changes, please run command:

./mill -i generate-reference-doc.run

Update the second parameter in @DirectiveUsage(usage: String, usageMd: String) which refer to markdown content.

@izzyreal izzyreal force-pushed the fix-inline-code-in-directives-docs branch from 677e6d4 to 1da4ea1 Compare June 21, 2023 12:28
@izzyreal
Copy link
Contributor Author

Thanks @lwronski, please check again
1da4ea1

@lwronski
Copy link
Contributor

@izzyreal, thank you! These changes will be available in the documentation after the release of Scala CLI 1.0.2.

@lwronski lwronski enabled auto-merge (squash) June 21, 2023 12:36
@lwronski lwronski merged commit 2c04327 into VirtusLab:main Jun 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants