feat: use the new ScalaAction from BSP4J #2284
Conversation
modules/options/src/main/scala/scala/build/actionable/ActionableDiagnostic.scala
Show resolved
Hide resolved
modules/core/src/main/scala/scala/build/errors/UnsupportedAmmoniteImportError.scala
Outdated
Show resolved
Hide resolved
|
Ahhh, I forgot to update the tests. I'll do that. |
This is a simplified version of VirtusLab#1969 that gets rid of the `ActionableDiagnostic` that is used internally and instead just ensures that any time a `TextEdit` is created there is a `title`. Then we take all the information already contained in the `Diagnostic` and make a `ScalaAction` from it to be forwarded via the diagnostic data.
|
I don't really get what's going on here @tgodzik, the native tests are failing with a null pointer exception and I don't really get why. Am I maybe missing something obvious? |
Hello @ckipp01, thank you for your contribution. It appears that there's some missing configuration for GraalVM, where reflection is used. I can help you with this tomorrow. |
Ahh of course, I forgot about that from my other pr. I just tried updated the reflect config with the new stuff that this adds from BSP4j. Hopefully that will do the trick. |
@ckipp01 Thanks, it seems to be working now. One job failed, but it's unrelated to your changes. A job restart should fix it. |
modules/options/src/main/scala/scala/build/actionable/ActionableDiagnostic.scala
Show resolved
Hide resolved
This is a simplified version of
#1969 that gets rid of the
ActionableDiagnosticthat is used internally and instead just ensures that any time aTextEditis created there is atitle. Then we take all the information already contained in theDiagnosticand make aScalaActionfrom it to be forwarded via the diagnostic data.