Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicitly passed scala version use the latest release, not the default one #2411

Merged

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Sep 21, 2023

E.g. make -S 2.13 expand to 2.13.12 even though our default for now is 2.13.11
Fixes #2394

@MaciejG604 MaciejG604 changed the title Make exlicitly passed scala version use the latest release, not the default one Make explicitly passed scala version use the latest release, not the default one Sep 21, 2023
@MaciejG604 MaciejG604 force-pushed the expand-scala-version-above-default branch from d0bfdee to d7fe0a3 Compare September 21, 2023 07:09
@MaciejG604
Copy link
Contributor Author

Copy link
Contributor

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt weird to me at first. But after some thought, I think I've convinced myself it's actually best. We don't want the default behavior to require doing a remote query (which might take time, or be blocked by a firewall or a container setting or what have you), and we also don't want someone's Scala version to suddenly change on them unless they either explicitly requested dynamic behavior (e.g. -S 2 or the like) or they upgraded scala-cli itself.

cc @lrytz

@lrytz
Copy link

lrytz commented Sep 21, 2023

@SethTisue I don't really follow; you say "we don't want the default behavior to require doing a remote query", but IIUC this PR does that, it will query to find out what's the latest release?

@SethTisue
Copy link
Contributor

@SethTisue I don't really follow; you say "we don't want the default behavior to require doing a remote query", but IIUC this PR does that, it will query to find out what's the latest release?

I meant what happens if you don't -S at all.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 merged commit 743b870 into VirtusLab:main Sep 22, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Scala versions are out of date
4 participants