Prevent resource directories from breaking sources hash #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/fix-resource-dir-cmdline-option
branch
from
8685a97
to
f77f2b1
Compare
tgodzik
approved these changes
Jan 8, 2024
MaciejG604
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirectly tied to #2621 (a compiler plugin could not be packaged when the resources were passed through a command line option instead of a directive)
This effectively fixes the (previously broken)
--resource-dircommand line option, as passing a resource directory through it forced sources hash to crash on the unhandled resource directory path.What's interesting, this did not happen when the resource directory was passed via a using directive.
Either way, sources hash should not be affected by the resources directory.