Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent consecutive -language:* options from being ignored #2667

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Jan 12, 2024

Depends on #2666
Depends on #2668
Fixes #2549

-language:* options can be passed multiple times to the compiler and thus aren't shadowable, so they shouldn't be treated as such.

@Gedochao Gedochao requested a review from tgodzik January 12, 2024 12:12
@Gedochao Gedochao marked this pull request as draft January 12, 2024 14:14
@Gedochao Gedochao force-pushed the maintenance/fix-consecutive-language-compiler-options branch from cf4e461 to 41125b0 Compare January 12, 2024 14:15
@Gedochao Gedochao force-pushed the maintenance/fix-consecutive-language-compiler-options branch from 41125b0 to 2db4649 Compare January 15, 2024 08:12
@Gedochao Gedochao marked this pull request as ready for review January 15, 2024 08:17
@Gedochao Gedochao merged commit 4339484 into VirtusLab:main Jan 15, 2024
58 checks passed
@Gedochao Gedochao deleted the maintenance/fix-consecutive-language-compiler-options branch January 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consecutive -language:... Compiler flags in using options are ignored
2 participants