Fix repeatable compiler options handling from the command line #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Jan 12, 2024
|
Thank you @Gedochao, is possible to release a new minor version of scala-cli for this bug fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2653
Repeatable compiler options (
-P:*:*and-Xplugin:*, specifically) were being filtered out on some code paths.This was happening as we do treat them differently, as they can't be shadowed. We have special handling for compiler options with keys which can be passed multiple times, as those cannot be overridden from the CLI when they're also being declared in a
usingdirective.@sequencer This may already be enough to cover your usecase from #2621. It still doesn't seem to work correctly with Bloop, but I can no longer replicate the problem with
--server=false(although it may be more complicated in yourmillbuild, so let's verify it after this gets merged).